Fix memory leak in #3 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everytime `Route.match` is being called by the app, it'll create a new instance of `shim.recordMiddleware` eventually causing a memory leak. I believe the fix for this is to just remove `this.Route.match = `, it'll also create neater traces in New Relic
Open
saqib-ahmed
approved these changes
Sep 14, 2022
|
Just in case someone's looking for a solution to this, you can use this node module until this PR gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everytime
Route.matchis being called by the app, it'll create a new instance ofshim.recordMiddlewareeventually causing a memory leak.I believe the fix for this is to just remove
this.Route.match =, it'll also create neater traces in New Relic