Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

Use userName, realName and password when connecting #216

Merged
merged 4 commits into from
Oct 12, 2017

Conversation

richrd
Copy link
Contributor

@richrd richrd commented Oct 12, 2017

Connecting to servers with passwords stopped working when teleirc switched to irc-framework. This fixes the issue. Also fixes #212 and #207 .

@Mikaela
Copy link
Collaborator

Mikaela commented Oct 12, 2017

Would you also be able to take a look at #207 & #212 which I think to be related?

I am not a coder and this looks bigger change than I am willing to merge, but I will ping others to take a look.

@richrd
Copy link
Contributor Author

richrd commented Oct 12, 2017

Yes. Those should be easy to add. I'll revise this PR (I noticed that it can be simplified too).

@richrd richrd changed the title Use password when connecting Use userName, realName and password when connecting Oct 12, 2017
@richrd
Copy link
Contributor Author

richrd commented Oct 12, 2017

Done.
Before:

12:00          * | tg (~ircbot@XXX.XXX.XXX.XXX)
12:00          * | ircname: ircbot
12:00          * | Channels: #ourchannel
12:00          * | Server: irc.ourserver.org Private IRC
12:00          * | Info: is connected via SSL (secure link)
12:00          * | Idle: since 0 days 0 hours 50 mins 39 secs Signed on: Thu Oct 12 11:01:07 2017
12:00          * | End of WHOIS

After:

12:01          * | tg (~tgbot@XXX.XXX.XXX.XXX)
12:01          * | ircname: Telegram IRC Bot
12:01          * | Channels: #ourchannel
12:01          * | Server: irc.ourserver.org Private IRC
12:01          * | Info: is connected via SSL (secure link)
12:01          * | Idle: since 0 days 0 hours 0 mins 6 secs Signed on: Thu Oct 12 12:01:14 2017
12:01          * | End of WHOIS

@Bysmyyr
Copy link
Collaborator

Bysmyyr commented Oct 12, 2017

looks good, I did not tested it but I trust you :P

@Bysmyyr Bysmyyr merged commit 226c7f8 into FruitieX:develop Oct 12, 2017
@richrd
Copy link
Contributor Author

richrd commented Oct 12, 2017

Thank you! Great to be able to run the official develop branch now. And now I get to benefit from the 'split-long-messages' fix 👍 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config.ircOptions realName does nothing
3 participants