This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
Imgur overhaul #252
Merged
Imgur overhaul #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tuupertunut
commented
May 15, 2018
Tuupertunut
commented
- Added support for uploading stickers to imgur.
- Added cache for imgur links (because the same stickers are often reused).
- It is stored in a JSON file in the config folder.
- Its size can be configured with the "imgurLinkCacheSize" option in the config file.
- Refactored the imgur code.
- It has been moved into its own file.
- It has proper error handling.
- It is written using ES2017 async/await.
The code is now much cleaner.
|
Jshint doesn't support ES2017 so the travis build will fail. |
|
Whoa, awesome stuff, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.