Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

Replace p.Name.Equals with String.Equals. Fixes issue #23. #26

Closed
wants to merge 1 commit into from
Closed

Replace p.Name.Equals with String.Equals. Fixes issue #23. #26

wants to merge 1 commit into from

Conversation

GeirGrusom
Copy link

No description provided.

@fubar-coder fubar-coder closed this May 5, 2015
@fubar-coder
Copy link
Contributor

I merged it manually, Thank you for your pull request.

@fubar-coder
Copy link
Contributor

Hi,

the difference is, that - in the old source - the Equals method is an instance method, while the string.Equals is a static method. The instance method cannot be called when Name is null, but the static method gracefully handles null strings.

Von meinem Windows Phone gesendet


Von: Simon Debaeckemailto:notifications@github.com
Gesendet: ‎05.‎05.‎2015 17:10
An: FubarDevelopment/restsharp.portablemailto:restsharp.portable@noreply.github.com
Betreff: Re: [restsharp.portable] Replace p.Name.Equals with String.Equals. Fixes issue #23. (#26)

Sorry but someone could tell the difference between these two comparisons methods ? O_o

Thx !


Reply to this email directly or view it on GitHubhttps://github.com//pull/26#issuecomment-99108914.

@simondebaecke
Copy link

Thank for the follow up ! (even though I have come to realize it shortly after asking my question, that's why I deleted it. ;))

@GeirGrusom GeirGrusom deleted the bugfix/issue-23 branch May 7, 2015 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants