Some view modes fixes and modifications (BigList,BigList2,SlimList,List) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burekas7
changed the title
Seperate Season poster dimensions from the other content types. Fix poster dimensions for general content type.
Note: This file on git was different from the last release version. The file was updated again according to the git and not according to the last release version.
Seperate Season poster dimensions from the other content types. Fix poster dimensions for general content type. Pay attention: This file on git was different from the last release version. The file was updated again according to the git and not according to the last release version.
Pay attention: This file on git was different from the last release version. The file was updated again according to the git and not according to the last release version.
Pay attention: This file on git was different from the last release version. The file was updated again according to the git and not according to the last release version.
This reverts commit 2b7fae2.
This reverts commit b40a776.
There is a bug with the current code with "HiddenOffset" (You see the word "poster" and the top-left corner of the window) It should be "HiddenObject". Fixed.
Some view modes fixes and modifications (List) Changed to HiddenObject instead of HiddenOffset There is a bug with the current code with "HiddenOffset" (You see some labels in the left side of the window) It should be "HiddenObject". Fixed.
Some view modes fixes and modifications (List) -> Changed to HiddenObject instead of HiddenOffset There is a bug with the current code with "HiddenOffset" (You see some labels in the left side of the window) It should be "HiddenObject". Fixed.
Some view modes fixes and modifications (List) -> Changed to HiddenObject instead of HiddenOffset There is a bug with the current code with "HiddenOffset" (You see some labels in the left side of the window) It should be "HiddenObject". Fixed.
Moving the last fixes here to another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Fuchs246
I have notice some differences from the original skin (Un Kodi Krypton) and some small bugs with the view modes.
These fixes mostly relates to all who use the same includes of "MovieDetailsLeft" ("MovieDetailsLeft_Layout")
Such as: BigList(51), BigList2(504), SlimList(516), etc. And mainly relates to Live TV.
So I decided to fix them.
Show information (Enabled):
IncludeViews.xml
Show large thumbnail (Enabled):
For Live TV:
Show large thumbnail (Disabled):
In general:
Screenshots: (After)
https://i.postimg.cc/fbySFM7X/Fix-Live-TVPreview.png
https://i.postimg.cc/jj1nYBv1/Fix-Live-TVLogo-With-Info.png
Show information (Disabled):
View_51_BigList.xml
View_504_BigList2.xml
View_516_SlimList.xml
Screenshot: (After)
https://i.postimg.cc/xCkHk9cY/Fix-Live-TVLogo-No-Info.png
View_50_List.xml
Screenhot: (After)
https://i.postimg.cc/8Pn762gz/Fix-List-Poster.png
Everything was tested.
Most of the changes relevant to Live TV but was tested also with TV Shows and Movies, and it remains ok.
Thanks.