Subtree toggle and cycle

[danskarda]

The patch adds two features:

• dired-subtree-toggle: show/hide directory subtree
• dired-subtree-cycle: org-mode like cycling between hide, show and recursive show

[Fuco1]

Very cool! I had this feature in my notes for a long time. I'll try to review it today evening.

Another cool thing would be to have an option to not expand certain directories, like .git, .hg or other similar "nonsense". I would imagine a customize variable where one can add filter functions taking the file path and deciding if we want to expand or not (say, if any of them returns true, we do not expand the directory).

We can then provide some filters (like "filter by name") but still leave the user option to add/remove their own filters.

Do you want to try to add such functionality to this PR? I'm merging it either way though, good job :)

[Fuco1]

So I've reviewed the patch and added a couple comments, mostly minor issues. Once you fix those I'll be happy to merge this in :).

[danskarda]

I updated code to match your coding style and fixed few typos.

I also added support for ignored files (defaults to vc-directory-exclusion-list). User can expand ignored directories explicitely.

[Fuco1]

Use string-match-p, the non -p version modifies the global match-data which might interfere with other packages. It is always better to use this if you don't care about the match data. (also fix the indent level :)

[Fuco1]

Awesome, two more little issues and it's ready. Thanks a bunch.

[danskarda]

Actually three issues. dired-subtree-cycle prefix was not working properly (fixed in last patch).

Should I squash patches?

[Fuco1]

Yes, please.

[danskarda]

Ready.

[Fuco1]

I only get the expantion down to 1 level and hide, the recursive one is never hit in the cond. I think the checks need to be reordered somehow.

Also, the variable is called dired-subtree--cycle-expanded but dired-subtree--cycle-previous is used. Did you lose a commit somewhere? :P

[danskarda]

You are right for the mismatch in variable name (typo).

About cycle not working. How do you execute dired-subtree-cycle?

I bound it to TAB and it works. Then I tried to execute it from helm-M-x (my default replacement for extended-command-execute) and it does not. It seems that Helm does not set properly last-command. This behavior is consistent with org-cycle which does not work either when executed from helm-M-x.

When I replaced helm-M-x with original extended-command-execute than dired-subtree-cycle works again.

Maybe you use helm-M-x or similar replacement which mishandles last-command?

[Fuco1]

I use smex but it is likely the same issue. Do you see some way to avoid using last-command?

There's some variable real-last-command, maybe we could investigate what it does.

[danskarda]

Same results with real-last-command :(

Other way I can think of is to use set-transient-map which is used by text-scale-adjust. The downside is that keys are hardwired (in text-scale-adjust) and it does not work with extended-command-execute replacements either.

So do you think fixing is worth the effort? I cannot imagine somebody using dired-subtree-cyle without hotkey (except for testing). The bug should be fixed in helm/smex. We can mention it in command documentation.

[Fuco1]

Agreed. Okey, I think we've solved everything then.

[Fuco1]

Thanks again.