Improve performance of delete-selection-pre-hook when no region is active #794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to the
delete-selection-pre-hook
advice to avoid unnecessary computations.I noticed sluggish responses when moving around some buffers; profiling revealed the advice to
delete-selection-pre-hook
to be the culprit. In particular, it repeatedly calledsp-wrap--can-wrap-p
, which ate a large fraction of CPU time. With this patch,sp-wrap--can-wrap-p
is only called when there actually is an active region. The additional condition is directly taken fromdelete-selection-pre-hook
; it is used there to decide whether to do something. With this small change, the problem of sluggish response times went away.