Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(repo): remove any kinda of nkey hardcoded #46

Merged
merged 21 commits into from
Jul 15, 2024
Merged

build(repo): remove any kinda of nkey hardcoded #46

merged 21 commits into from
Jul 15, 2024

Conversation

pedronauck
Copy link
Collaborator

@pedronauck pedronauck commented Jul 8, 2024 •
edited
Loading

⭐ Closes #44
⭐ Closes #43

@pedronauck pedronauck self-assigned this Jul 8, 2024
@pedronauck pedronauck marked this pull request as draft July 8, 2024 19:52
@pedronauck pedronauck marked this pull request as ready for review July 8, 2024 23:08
Jurshsmith
Jurshsmith requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@Jurshsmith Jurshsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on cleaning up the Make commands -- looks much better 👍. I just have a little concern with the new NKey implementation.

.env.sample Show resolved Hide resolved
crates/fuel-core-nats/src/lib.rs Outdated Show resolved Hide resolved
crates/fuel-core-nats/src/lib.rs Outdated Show resolved Hide resolved
crates/fuel-core-nats/src/lib.rs Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Jurshsmith
Jurshsmith requested changes Jul 10, 2024
View reviewed changes
crates/fuel-core-nats/src/main.rs Outdated Show resolved Hide resolved
crates/fuel-core-nats/src/main.rs Outdated Show resolved Hide resolved
crates/fuel-core-nats/src/lib.rs Outdated Show resolved Hide resolved
@pedronauck pedronauck enabled auto-merge (squash) July 13, 2024 02:33
@pedronauck pedronauck merged commit e99af0f into main Jul 15, 2024
7 checks passed
@pedronauck pedronauck deleted the pn/build/nkey-env branch July 15, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jurshsmith Jurshsmith Jurshsmith approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@lostman lostman Awaiting requested review from lostman lostman is a code owner

Assignees

@pedronauck pedronauck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add nkey user as environment variable instead of hard coded Add CI checks for tests
2 participants
@pedronauck @Jurshsmith