feat(data-stream): add publishing tests #48
Merged
+440
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jurshsmith
requested review from
luizstacio,
pedronauck and
lostman
as code owners
This trait describes the interface required for `fuel-core-nats` to extend `fuel-core`. Equally, it will be useful for mocking fuel-core related components in our integration tests.
A subject prefix could be empty ("") or some random string value. This helps
contextualize each text case and could come in handy for other sandboxing
usecases in the future.
Jurshsmith
force-pushed
the
aj/feat/fuel-core-nats-publishing-tests
branch
from
176527f
to
0d872ab
Compare
based on the new tech spec, these subjects will have a new data structure making the current implementation stale.
pedronauck
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides populating the tests related to publishing NATS subjects, this PR does the following:
and allow building each subject and their names in a type-safe manner.
connection_idoptionally to contextualize each NATS connection. This willallow us to run tests in parallel and equally might serve some sandboxing use cases in the future.