Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libpq to docker image, add script and readme #5

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Apr 25, 2024

  • Installs libpq in the docker file. This was causing deployment to fail since it's a dependency of diesel.
  • Replaces DATABASE_URL with a function that constructs the url since .env won't be copied to the deployed image anyway. This is handled in the deployment repo
  • Adds more info about local development to the readme
  • Adds the redirect URI so that github login will work locally and in production
  • Adds a script for starting and restarting the server in docker. It uses docker network to communicate with the postgres container. The postgres container can still be run on it's own and works with the server when the server is started with cargo run instead of docker.

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
forc-pub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 10:30pm

@sdankel sdankel requested a review from a team April 25, 2024 22:31
@sdankel sdankel marked this pull request as ready for review April 25, 2024 22:31
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing up the build instructions.

Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sdankel sdankel merged commit b964b49 into master Apr 26, 2024
11 checks passed
@sdankel sdankel deleted the sophie/docker-libpq branch April 26, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants