Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOB Findings 3 & 4 #5

Closed
DefiCake opened this issue Jul 12, 2023 · 0 comments · Fixed by #4
Closed

TOB Findings 3 & 4 #5

DefiCake opened this issue Jul 12, 2023 · 0 comments · Fixed by #4

Comments

@DefiCake
Copy link
Member

TOB Finding 3:

DescriptionWhen a refund is registered due to an error, any previous refund balance is overwrittenand lost.Refunds are issued when the bridged Ethereum asset is sent to an incompatible tokenaddress on the Fuel chain.

https://github.com/FuelLabs/fuel-bridge/blob/0861c0c57a3f3125f5ed28e16fdd883624343efd/packages/fungible-token/bridge-fungible-token/src/bridge_fungible_token.sw#L192C14-L192C14

TOB Finding 4:

DescriptionFunds in the FuelERC20Gateway can be drained due to returning an incorrect asset whenclaiming a refund.

https://github.com/FuelLabs/fuel-bridge/blob/0861c0c57a3f3125f5ed28e16fdd883624343efd/packages/fungible-token/bridge-fungible-token/src/bridge_fungible_token.sw#L132C18-L132C18
@DefiCake DefiCake mentioned this issue Jul 12, 2023
Merged
DefiCake added a commit that referenced this issue Jul 14, 2023
@DefiCake @Braqzen
Address trail of bits issues (#4)
3df9609 
fix: address trail of bits issues - register_refund overwrite and incorrect refund registering for wrong tokens

Closes #5

---------

Co-authored-by: Braqzen <103777923+Braqzen@users.noreply.github.com>
This was referenced Aug 26, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address trail of bits issues FuelLabs/fuel-bridge
1 participant
@DefiCake