-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace FRC20 with SRC20 #102
Conversation
packages/fungible-token/bridge-fungible-token/src/interface/bridge.sw
Outdated
Show resolved
Hide resolved
packages/fungible-token/bridge-fungible-token/tests/functions/src20/mod.rs
Outdated
Show resolved
Hide resolved
packages/fungible-token/bridge-fungible-token/tests/functions/src20/mod.rs
Outdated
Show resolved
Hide resolved
packages/fungible-token/bridge-fungible-token/src/interface/bridge.sw
Outdated
Show resolved
Hide resolved
packages/fungible-token/bridge-fungible-token/tests/functions/src20/mod.rs
Outdated
Show resolved
Hide resolved
packages/fungible-token/bridge-fungible-token/tests/functions/src20/mod.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bitzoic what do you think about the SRC20 here? It's a little different
packages/fungible-token/bridge-fungible-token/tests/functions/bridge/mod.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the SRC-20 standard you no longer need the empty spaces at the end of your configurable for NAME
and SYMBOL
. If every bridged token is using the same name then just "MyToken" or "BridgedAsset" will suffice. I'm also unsure if every asset bridged uses the same decimals and it should be a constant i.e. NFTs and high supply assets but I don't know the specific implementation that is happening here.
Co-authored-by: Cameron Carstens <54727135+bitzoic@users.noreply.github.com>
Co-authored-by: Cameron Carstens <54727135+bitzoic@users.noreply.github.com>
Co-authored-by: Cameron Carstens <54727135+bitzoic@users.noreply.github.com>
packages/fungible-token/bridge-fungible-token/tests/functions/message_receiver/mod.rs
Show resolved
Hide resolved
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @fuel-bridge/fungible-token@0.4.0 ### Minor Changes - Update to fuel-core 0.22.0 (beta-5), by [@LuizAsFight](https://github.com/LuizAsFight) (See [#106](#106)) - Replace FRC20 with SRC20, by [@DefiCake](https://github.com/DefiCake) (See [#102](#102)) - Use sway 0.48.1 and migrate from U256 to u256, by [@LuizAsFight](https://github.com/LuizAsFight) (See [#106](#106)) - Bumped fuels to 0.50.1, by [@DefiCake](https://github.com/DefiCake) (See [#95](#95)) ## @fuel-bridge/message-predicates@0.4.0 ### Minor Changes - Update to fuel-core 0.22.0 (beta-5), by [@LuizAsFight](https://github.com/LuizAsFight) (See [#106](#106)) - Bumped fuels to 0.50.1, by [@DefiCake](https://github.com/DefiCake) (See [#95](#95)) ## @fuel-bridge/solidity-contracts@0.4.0 ### Minor Changes - ERC20 gateway with training wheels, by [@DefiCake](https://github.com/DefiCake) (See [#100](#100)) - Added deposit caps for native base asset (eth), by [@DefiCake](https://github.com/DefiCake) (See [#97](#97)) ### Patch Changes - 🐞 Fix prettier and apply it to current files, by [@DefiCake](https://github.com/DefiCake) (See [#98](#98)) - Remove deposit limitations on ether, by [@DefiCake](https://github.com/DefiCake) (See [#101](#101)) - Add deploy scripts, by [@DefiCake](https://github.com/DefiCake) (See [#107](#107)) - Add beta 5 deployment artifacts, by [@DefiCake](https://github.com/DefiCake) (See [#110](#110)) ## @fuel-bridge/test-utils@0.4.0 ### Minor Changes - Update to fuel-core 0.22.0 (beta-5), by [@LuizAsFight](https://github.com/LuizAsFight) (See [#106](#106)) ### Patch Changes - ✨ feat: update fuels-ts to 0.71.1, by [@LuizAsFight](https://github.com/LuizAsFight) (See [#118](#118)) --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: DefiCake <rarore92@gmail.com>
No description provided.