Skip to content

Commit

Permalink
Applied comments from PR
Browse files Browse the repository at this point in the history
  • Loading branch information
xgreenx committed May 16, 2024
1 parent f6fa43d commit 6dcdb04
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ jobs:
args: -p fuel-core-client --no-default-features
- command: test
args: -p fuel-core-chain-config --no-default-features
# Don't split this command; this is a workaround.
# We need to run `cargo check` first to fetch the locked dependencies
# for `fuel-core 0.26.0`(because of the bug with `--offline`
# and `--locked` when we build `fuel-core-wasm-executor 0.26.0`).
- command: check
args: --manifest-path version-compatibility/Cargo.toml --workspace && cargo test --manifest-path version-compatibility/Cargo.toml --workspace
- command: build
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use libp2p::{
use std::time::Duration;

#[tokio::test]
async fn latest_binary_can_load_testnet_config() {
async fn latest_binary_is_backward_compatible_and_can_load_testnet_config() {
// When
let latest_node = LatestFuelCoreDriver::spawn(&[
"--debug",
Expand All @@ -38,7 +38,8 @@ async fn latest_binary_can_load_testnet_config() {
}

#[tokio::test]
async fn latest_binary_follows_blocks_created_by_genesis_binary() {
async fn latest_binary_is_backward_compatible_and_follows_blocks_created_by_genesis_binary(
) {
// Given
let genesis_keypair = SecpKeypair::generate();
let hexed_secret = hex::encode(genesis_keypair.secret().to_bytes());
Expand All @@ -65,7 +66,7 @@ async fn latest_binary_follows_blocks_created_by_genesis_binary() {
let genesis_peer_id = PeerId::from_public_key(&public_key);
let genesis_multiaddr = default_multiaddr(genesis_port, genesis_peer_id);

// Starting node that uses latest furl core.
// Starting node that uses latest fuel core.
// It will connect to the genesis node and sync blocks.
let latest_keypair = SecpKeypair::generate();
let hexed_secret = hex::encode(latest_keypair.secret().to_bytes());
Expand Down

0 comments on commit 6dcdb04

Please sign in to comment.