Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account the actually used gas by the transactions and fetch more transaction #1217

Closed
xgreenx opened this issue Jun 18, 2023 · 0 comments · Fixed by #1223
Closed
Assignees

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Jun 18, 2023

Beta 3 and upcoming beta 4 suffer the problem with transactions with a 10M gas limit, but the actual used gas is 5K. TX pool only returns 50 transactions because the max gas limit of the block is 500M. It decreases the tps of the blockchain, and users can't commit a lot of transactions.

We need to update the transaction selection logic to be a stream like in #1206. This issue tracks only the streaming implementation of the transaction selection, and the soft commit part should be done during the parent issue.

Also, we need to patch the latest 0.17 and 0.18 releases with this fix.

During development, we need to consider that this stream will be later used during parallel execution.

@xgreenx xgreenx self-assigned this Jun 19, 2023
xgreenx added a commit that referenced this issue Jun 21, 2023
…ransactions if we can (#1220)

The PR implements #1217 for
the beta 3 testnet

---------

Co-authored-by: Elvis <elvisdedic@outlook.com>
xgreenx added a commit that referenced this issue Jun 22, 2023
… more transaction (#1223)

Closes #1217 for the
`master`.

Release `0.17.13` was packed with the same change
#1220

---------

Co-authored-by: Elvis <elvisdedic@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant