Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent gossip of invalid txs #595

Closed
Tracked by #479
Voxelot opened this issue Sep 7, 2022 · 1 comment · Fixed by #936
Closed
Tracked by #479

prevent gossip of invalid txs #595

Voxelot opened this issue Sep 7, 2022 · 1 comment · Fixed by #936
Assignees
@leviathanbeak

Comments

@Voxelot
Copy link
Member

Voxelot commented Sep 7, 2022 •
edited

When a node encounters an invalid tx, it shouldn't propagate to the rest of the network.
@Voxelot Voxelot mentioned this issue Sep 7, 2022
Closed
6 tasks
@leviathanbeak leviathanbeak mentioned this issue Sep 27, 2022
Draft
@Voxelot Voxelot mentioned this issue Sep 30, 2022
Merged
@Voxelot
Copy link
Member Author

Voxelot commented Jan 5, 2023

utilize notify_gossip_transaction_validity

@leviathanbeak leviathanbeak self-assigned this Jan 24, 2023
@leviathanbeak leviathanbeak mentioned this issue Jan 25, 2023
Merged
Voxelot added a commit that referenced this issue Jan 26, 2023
@leviathanbeak @xgreenx @Voxelot
add message validation for gossipsub messages from txpool (#936)
1542d93 
Closes #595 

For gossipsub messages, we need to validate **all** the messages.
Messages will not be propagated unless a _timely_ validation is
reported.

I have updated the gossipsub tests, now instead of just checking that
Node A sends a gossipsub message to Node B,
we also check that Node C gets the propagated message from Node B.
Of course if the validation is positive, if the message is rejected Node
C should not receive it.

Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
Co-authored-by: Voxelot <brandonkite92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leviathanbeak leviathanbeak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add message validation for gossipsub messages from txpool FuelLabs/fuel-core
2 participants
@Voxelot @leviathanbeak