Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove txs from txpool without dependencies #868

Open
Voxelot opened this issue Dec 23, 2022 · 1 comment
Open

Remove txs from txpool without dependencies #868

Voxelot opened this issue Dec 23, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Voxelot
Copy link
Member

Voxelot commented Dec 23, 2022

When a block is produced or imported, the associated txs need to be removed from the pool. However, our current removal method assumes that the tx and all it's dependencies should be removed. This is problematic as the dependent txs may be unnecessarily removed from the txpool.

Expected behavior:

  • when a block is imported
    • the txs that were successfully process should be removed and their dependencies should be kept
    • txs that were skipped should be removed along with any dependencies
  • when transactions are selected for block production
    • they should be removed without removing dependencies, but the depth of the dependencies should be updated
    • any skipped transactions from block production should also remove dependents in the txpool, although this should be handled by the same mechanism as block import
@xgreenx
Copy link
Collaborator

xgreenx commented Aug 16, 2023

Related to #1229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants