Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client URL parsing #293

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Update client URL parsing #293

merged 2 commits into from
Apr 28, 2022

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Apr 28, 2022

Before when creating the fuel-gql-client it was expecting the URL to also contain the expected endpoint /graphql. This PR allows users to just set a base URL for the node, and then the client will automatically set the correct path to the api.

@Voxelot Voxelot self-assigned this Apr 28, 2022
adlerjohn
adlerjohn previously approved these changes Apr 28, 2022
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Voxelot Voxelot merged commit b66a4e0 into master Apr 28, 2022
@Voxelot Voxelot deleted the client-url-parse branch April 28, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants