Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WalletConnect and SolanaConnector in bridge #414

Open
LuizAsFight opened this issue Jul 11, 2024 · 0 comments
Open

Add WalletConnect and SolanaConnector in bridge #414

LuizAsFight opened this issue Jul 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working p0 For yesterday. critical bugs / big priorities

Comments

@LuizAsFight
Copy link
Contributor

LuizAsFight commented Jul 11, 2024

WalletConnect connector is currently removed from bridge because of a conflict in wagmi

Connectors from ETH side(wallet connect) and from FUEL side (eth wallets) are conflicting because they internally use the same wagmi lib

The fuel connectors work fine alone, this is a problem only in the bridge, as it's needed to have both ETH and FUEL wallet connected at same time.

This issue aims to fix the problem in the bridge layer:

  • Add Solana and WalletConnect connectors
  • Fix the behaviors to work smoothly (as it works based on same window.ethereum , we cannot support multi wallets in this case
    • When connect one account in ETH wallet (both in ETH or FUEL side), it should automatically connect the same account in the other network.
    • When disconnect from one side, it should automatically disconnect the other side
    • Same thing for other actions, like changing account inside metamask. They should affect both side of connections (eth and fuel)

PS: to execute this issue:

  • it will be needed to update the @fuels/connectors and @fuels/react libs
  • maybe will be needed to update TS SDK version / fuel-core version. we should only update if it's really needed, as the purpose of this issue is to fix this p0 bug. the update can come later in another PR
@LuizAsFight LuizAsFight added bug Something isn't working p0 For yesterday. critical bugs / big priorities labels Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0 For yesterday. critical bugs / big priorities
Projects
None yet
Development

No branches or pull requests

2 participants