Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made manifest contract_id work with both namespaced and non-namespaced contract IDs #1326

Merged
merged 10 commits into from
Sep 11, 2023
Merged

Made manifest contract_id work with both namespaced and non-namespaced contract IDs #1326

merged 10 commits into from
Sep 11, 2023

Conversation

dadepo
Copy link
Contributor

@dadepo dadepo commented Sep 2, 2023

Closes #1137

Description

Made manifest contract_id work with both namespaced and non-namespaced contract IDs

Changelog

Updated the logic that parses the address in the manifest to Bech32ContractId to work with both namespace and non-space addresses.

@dadepo dadepo marked this pull request as ready for review September 2, 2023 10:30
ra0x3
ra0x3 suggested changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@ra0x3 ra0x3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadepo

  • Looks mostly ok, left some minor feedback
  • If you want to add a blurb to the docs, you can open manifest.md, go to the contract_id section, an add the following as a quote/blurb:

Note that this parameter supports both Bech32 contract IDs and non-Bech32 contract IDs

examples/fuel-explorer/fuel-explorer/fuel_explorer.manifest.yaml Outdated Show resolved Hide resolved
examples/hello-world-native/hello-indexer-native/hello_indexer_native.manifest.yaml Outdated Show resolved Hide resolved
examples/hello-world/hello-indexer/hello_indexer.manifest.yaml Outdated Show resolved Hide resolved
packages/fuel-indexer-macros/src/indexer.rs Show resolved Hide resolved
packages/fuel-indexer-tests/indexers/fuel-indexer-test/fuel_indexer_test.yaml Outdated Show resolved Hide resolved
plugins/forc-index/src/defaults.rs Outdated Show resolved Hide resolved
@ra0x3
Copy link
Contributor

ra0x3 commented Sep 8, 2023

@dadepo

  • This looks ok. Give us a bit of time and we'll get it merged for you :)
  • Really need to spend some time to figure out how to get 3rd-party contributors to run CI using the same tokens we (internal contributors) use

@deekerno deekerno mentioned this pull request Sep 11, 2023
Closed
deekerno
deekerno approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@deekerno deekerno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually tested this and it works. 👌🏽

@ra0x3 ra0x3 merged commit a7832cb into FuelLabs:develop Sep 11, 2023
17 of 19 checks passed
@dadepo dadepo deleted the 1137/contract_id-work-with-namespace-and-non-namespace branch September 12, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ra0x3 ra0x3 ra0x3 requested changes

@deekerno deekerno deekerno approved these changes

@lostman lostman Awaiting requested review from lostman lostman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make manifest contract_id work with both namespaced and non-namespaced contract IDs
3 participants
@dadepo @ra0x3 @deekerno