Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: add predicate support #1381

Closed
wants to merge 2 commits into from
Closed

enhancement: add predicate support #1381

wants to merge 2 commits into from

Conversation

ra0x3
Copy link
Contributor

@ra0x3 ra0x3 commented Sep 26, 2023

Thanks for opening a PR with the Fuel Indexer project. Please review the Checklist below and ensure you've completed all of the necessary steps to make this PR review as painless as possible.

Checklist

  • Ensure your top-level commit message is in line with our contributor guidelines.
  • Please add proper labels.
  • If there is an issue associated with this PR, please link the issue (right-hand sidebar)
  • If there is not an issue associated with this PR, add this PR to the "Fuel Indexer" project (right-hand sidebar)
  • Please allow Codeowners at least 24 hours to do a first-pass review.
  • Please add thoroughly detailed testing steps below.
  • Please keep your Changelog message short and sweet.

Description

Please include a short description of what this PR does.

Testing steps

Please provide the exact testing steps for the reviewer(s) if this PR requires testing.

Changelog

Please add neat Changelog info here, according to our Contributor's Guide.

@ra0x3 ra0x3 self-assigned this Sep 26, 2023
@ra0x3 ra0x3 linked an issue Sep 26, 2023 that may be closed by this pull request
Add predicate support #886
Open
@ra0x3 ra0x3 marked this pull request as draft September 26, 2023 20:48
@ra0x3 ra0x3 force-pushed the rashad/add-predicate-support branch from a6ddad8 to 73a81cc Compare September 29, 2023 17:32
@ra0x3 ra0x3 added the breaking This is a change that will break some component of the project once merged to origin/develop label Oct 3, 2023
@ra0x3 ra0x3 force-pushed the rashad/add-predicate-support branch from 2442d6e to a9e2e89 Compare October 5, 2023 20:15
@ra0x3 ra0x3 mentioned this pull request Oct 5, 2023
Merged
7 tasks
@ra0x3 ra0x3 force-pushed the rashad/add-predicate-support branch 3 times, most recently from 2050b21 to d68abcc Compare October 12, 2023 14:27
@ra0x3 ra0x3 added the blocked This change is currently blocked by a linked issue label Oct 12, 2023
@ra0x3
Copy link
Contributor Author

ra0x3 commented Oct 12, 2023

Temporarily blocked by FuelLabs/fuels-rs#1165

@ra0x3 ra0x3 force-pushed the rashad/add-predicate-support branch 3 times, most recently from 4f65d8c to aca1298 Compare October 24, 2023 15:15
@ra0x3 ra0x3 removed the blocked This change is currently blocked by a linked issue label Oct 26, 2023
@ra0x3 ra0x3 force-pushed the rashad/add-predicate-support branch 2 times, most recently from f25910d to a274e52 Compare November 2, 2023 15:29
@ra0x3 ra0x3 added the blocked This change is currently blocked by a linked issue label Nov 6, 2023
@ra0x3 ra0x3 force-pushed the rashad/add-predicate-support branch from a274e52 to 07049a4 Compare November 10, 2023 16:30
@ra0x3 ra0x3 removed the blocked This change is currently blocked by a linked issue label Nov 14, 2023
@ra0x3 ra0x3 force-pushed the rashad/add-predicate-support branch 2 times, most recently from f687459 to 220eb96 Compare November 16, 2023 15:46
ra0x3
ra0x3 commented Nov 16, 2023
View reviewed changes
packages/fuel-indexer-tests/src/lib.rs
// repo for all test asset paths (i.e., we can simply reference all asset paths in
// in manifest files relative from 'fuel-indexer')
pub fn test_indexer_updated_manifest() -> Manifest {
// TODO: Write a CI check for this
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget this

@ra0x3 ra0x3 force-pushed the rashad/add-predicate-support branch 3 times, most recently from 575a699 to d891822 Compare November 20, 2023 17:47
@ra0x3 ra0x3 force-pushed the rashad/add-predicate-support branch 2 times, most recently from eb041f2 to 01fd53f Compare November 21, 2023 02:26
@ra0x3 ra0x3 added big documentation Improvements or additions to documentation labels Nov 21, 2023
@ra0x3 ra0x3 mentioned this pull request Nov 28, 2023
Closed
4 tasks
@ra0x3 ra0x3 force-pushed the rashad/add-predicate-support branch 5 times, most recently from 39ae355 to 201a555 Compare December 2, 2023 15:00
@ra0x3 ra0x3 mentioned this pull request Dec 4, 2023
Open
dmihal
dmihal reviewed Dec 4, 2023
View reviewed changes
Copy link

@dmihal dmihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that this proposal only indexes predicates once they're included with inputs in a transaction.

Does this solve the use case that projects like Spark want to handle? Which is primarily indexing the predicate before it's assets get spent?

docs/src/indexing-fuel-types/predicates.md Show resolved Hide resolved
docs/src/indexing-fuel-types/predicates.md Show resolved Hide resolved
docs/src/indexing-fuel-types/predicates.md Show resolved Hide resolved
@ra0x3
Copy link
Contributor Author

ra0x3 commented Dec 4, 2023

@dmihal

  • This PR is in draft, so not ready for anyones eyes
  • I'll ping you when it's ready for review 👌🏼

@ra0x3
Copy link
Contributor Author

ra0x3 commented Dec 4, 2023

It appears that this proposal only indexes predicates once they're included with inputs in a transaction.

Does this solve the use case that projects like Spark want to handle? Which is primarily indexing the predicate before it's assets get spent?

It appears that this proposal only indexes predicates once they're included with inputs in a transaction.

Does this solve the use case that projects like Spark want to handle? Which is primarily indexing the predicate before it's assets get spent?

@dmihal This does support indexing when a predicate is "created" and "spent". For details on the flow, feel free to read the comment here

@ra0x3 ra0x3 force-pushed the rashad/add-predicate-support branch from 201a555 to 3180fb3 Compare December 4, 2023 22:47
@deekerno deekerno closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmihal dmihal dmihal left review comments

@deekerno deekerno Awaiting requested review from deekerno

@lostman lostman Awaiting requested review from lostman lostman is a code owner

Assignees

@ra0x3 ra0x3

Labels
big breaking This is a change that will break some component of the project once merged to origin/develop documentation Improvements or additions to documentation work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add predicate support
3 participants
@ra0x3 @dmihal @deekerno