Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include std feature on strum dependency #1522

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

deekerno
Copy link
Contributor

Description

Includes std feature for strum in fuel-indexer-api-server.

Testing steps

For some odd reason, I was unable to build the fuel-indexer package due to the following error:

error[E0599]: the method `as_dyn_error` exists for reference `&ParseError`, but its trait bounds were not satisfied
   --> packages/fuel-indexer-api-server/src/api.rs:105:18
    |
105 |     ParseError(#[from] strum::ParseError),
    |                  ^^^^ method cannot be called on `&ParseError` due to unsatisfied trait bounds
    |

Try to build on develop, and then try to build on this branch; you should see that it works in the latter.

@deekerno deekerno added the bug Something isn't working label Jan 30, 2024
@deekerno deekerno self-assigned this Jan 30, 2024
@deekerno deekerno marked this pull request as ready for review January 30, 2024 19:10
Copy link
Contributor

@ra0x3 ra0x3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ra0x3 ra0x3 merged commit a6bc822 into develop Jan 30, 2024
20 checks passed
@ra0x3 ra0x3 deleted the deekerno/fix-strum-feature-flags branch January 30, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants