-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add support for unindexable types #943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ra0x3
commented
May 23, 2023
deekerno
reviewed
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good; the latest changes from master need to be integrated as the playground shows an error and the docs/schema don't load. But I'm sure they'll work after updating.
Left a couple of comments about readability.
deekerno
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@norelation
directiveNoRelation
, which means the object is stored asJson
Json
overBlob
because I think it might be easier to extract the item into an objectserialize
anddeserialize
from fuel-indexer-schema to fuel-indexer-lib)Testing steps
bash scripts/utils/build_test_wasm_module.bash
cargo run -p fuel-node --bin fuel-node
cargo run -p web-api --bin web-api
curl -X POST http://localhost:8000/block
http://localhost:29987/api/playground/fuel_indexer_test/index1
NoRelationEntity
already comes back as an object straight from the DB, so no further deserialization is neededChangelog
@norelation
directive that does not create SQL tables for entities