New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granular Asset Minting #491
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5b45319
Update instruction_set.md
SilentCicero 062375e
Update instruction_set.md
SilentCicero d3c6e87
Update instruction_set.md
SilentCicero 27f7e69
Create asset.md
SilentCicero 045bbc3
Update index.md
SilentCicero e886b34
Update instruction_set.md
SilentCicero 2698ee6
Update receipts.md
SilentCicero 816362b
Update instruction_set.md
SilentCicero c4aab7a
Update SUB_IDENTIFIER
SilentCicero 3e9fdfd
Small nits.
SilentCicero c7610c6
Small nits.
SilentCicero b48cdd6
sub_id
SilentCicero 62e613f
sub_id in receipts.
SilentCicero 65b03c7
Update transaction.md
SilentCicero e3d430b
Merge remote-tracking branch 'origin/master' into SilentCicero-multi-…
Voxelot 1a421c9
merge conflicts
Voxelot 7cd030c
fix links
Voxelot 351eff1
fix asset id construction
Voxelot 83f555b
Merge branch 'master' into SilentCicero-multi-token
xgreenx c318dcc
Merge branch 'master' into SilentCicero-multi-token
Voxelot 4c88a94
Apply suggestions from code review
Voxelot File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# Asset ID | ||
|
||
The _asset ID_ (also called _asset hash_) of a asset is computed as | ||
the [hash](../protocol/cryptographic-primitives.md#hashing) of the `CONTRACT_ID` and a 256-bit `SUB_IDENTIFIER`. | ||
|
||
```python | ||
sha256(CONTRACT_ID ++ SUB_IDENTIFIER) | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this breaks our convention of using
id
for the contract like other receipts. Any particular reason we used contract_id instead of justid
? cc @SilentCicero @dmihalThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice to avoid confusion, since this interaction has 3 different IDs (contract ID, asset ID & sub-ID)
If we want to stay consistent, would it make sense to change
id
tocontract_id
in the other receipts?