-
Notifications
You must be signed in to change notification settings - Fork 2
Replace hashed input UtxoId with pair of (txID,outputIndex) #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a feature branch on fuel-vm and fuel-core with these changes working before merging. That way we don't wind up incrementally publishing fuel-tx as we troubleshoot. |
Added a few more things to UtxoId (Copy,LowerHex,UpperHex,FromStr), and integrated new UtxoId into fuel-core here: https://github.com/FuelLabs/fuel-core/tree/utxo_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits/discussions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He is on vacation and all nitpicks were addressed in proper maner and approved by Brandon and John.
@adlerjohn @Voxelot i will need you to approve this once again, nothing has changed. |
Change related to spec: FuelLabs/fuel-specs#253
Additionally i run clippy and fixed its warning. And there was one error that clippy gave:
is_empty
and `unwrap_or_else are clippy requests (she is very needy).When this is merged i will go through other projects and fix if there is something broken.