Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: setup escrow with the appropriate project structure #36

Merged
merged 4 commits into from
May 25, 2022

Conversation

matt-user
Copy link
Contributor

closes #27

@matt-user matt-user added the enhancement New feature or request label May 25, 2022
@matt-user matt-user self-assigned this May 25, 2022
apps/escrow/frontend/README.md Outdated Show resolved Hide resolved
apps/escrow/frontend/README.md Outdated Show resolved Hide resolved
apps/escrow/frontend/README.md Show resolved Hide resolved
apps/escrow/frontend/README.md Outdated Show resolved Hide resolved
apps/escrow/frontend/README.md Outdated Show resolved Hide resolved
apps/escrow/frontend/src/systems/Core/index.tsx Outdated Show resolved Hide resolved
apps/escrow/frontend/src/systems/Core/pages/Escrow.tsx Outdated Show resolved Hide resolved
apps/escrow/frontend/src/systems/Core/types/pages.ts Outdated Show resolved Hide resolved
navigate(Pages.escrow);
}

return (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a create wallet page it would be better to jump straight into the escrow page and have an option to create as many escrows as we like (depending on the balance of each wallet).

Then we could switch between each wallet and have it render whatever escrows that wallet has deployed.
Moreover, we could have a drop down similar to what remix has with its addresses. This way the user can easily switch between a set of predetermined addresses that already have some balance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, we can just create and fund the wallets for the user.

I agree that we should be able to switch between wallets and render that wallets deployed escrows.

@matt-user matt-user requested a review from Braqzen May 25, 2022 19:57
@Braqzen
Copy link

Braqzen commented May 25, 2022

You may want another dev to glance through the code

@matt-user matt-user closed this May 25, 2022
@matt-user matt-user reopened this May 25, 2022
@matt-user
Copy link
Contributor Author

You may want another dev to glance through the code

@LuizAsFight @luizstacio @pedronauck if someone could give this a quick glance that would be great, thanks!

@matt-user matt-user merged commit 76086c6 into master May 25, 2022
@matt-user matt-user deleted the mattauer/feat-escrow-frontend branch May 25, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: basic project setup
2 participants