-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: setup escrow with the appropriate project structure #36
Conversation
navigate(Pages.escrow); | ||
} | ||
|
||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of a create wallet page it would be better to jump straight into the escrow page and have an option to create as many escrows as we like (depending on the balance of each wallet).
Then we could switch between each wallet and have it render whatever escrows that wallet has deployed.
Moreover, we could have a drop down similar to what remix has with its addresses. This way the user can easily switch between a set of predetermined addresses that already have some balance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, we can just create and fund the wallets for the user.
I agree that we should be able to switch between wallets and render that wallets deployed escrows.
You may want another dev to glance through the code |
@LuizAsFight @luizstacio @pedronauck if someone could give this a quick glance that would be great, thanks! |
closes #27