Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Simplified Header Checks, TODOs, Token ID Constraints, WitnessCommitted Event, HTLC #18

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Simplified Header Checks, TODOs, Token ID Constraints, WitnessCommitted Event, HTLC #18

merged 4 commits into from
Jul 9, 2020

Conversation

SilentCicero
Copy link
Member

@SilentCicero SilentCicero commented Jul 9, 2020 •
edited
Loading

Changes

  • Simplified the verifyHeader checks to just a hash, all tests pass
  • Address all documentation TODO's and removals of unused code
  • Added Token ID restraints to Deposit / InvalidTransaction fraud cases, limit now at length of lte 4 bytes or 0xFFFFFFFF
  • Added WitnessCommitted Event for clarity and composure, added event checking test case
  • Changed ethereumBlockNumber property to blockNumber for consistency and clarity, all tests pass
  • HTLC timeout now in blockNumber not blockHeight for InvalidInput fraud prover

@SilentCicero SilentCicero added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jul 9, 2020
This was referenced Jul 9, 2020
Closed
Closed
Closed
Closed
@SilentCicero SilentCicero changed the title Simplified Header Checks, TODOs, Token ID Constraints, WitnessCommitted Event Simplified Header Checks, TODOs, Token ID Constraints, WitnessCommitted Event, HTLC Jul 9, 2020
This was linked to issues Jul 9, 2020
Add check that token IDs are at most 4 bytes #11
Closed
Timelock should use Ethereum block number #12
Closed
Add event for new witness registration #13
Closed
Simplify block header verify to just compare hashes #16
Closed
@adlerjohn adlerjohn self-requested a review July 9, 2020 18:02
adlerjohn
adlerjohn suggested changes Jul 9, 2020
View reviewed changes
src/Tokens.yulp Outdated Show resolved Hide resolved
@adlerjohn adlerjohn merged commit 4f04b86 into master Jul 9, 2020
@adlerjohn adlerjohn deleted the silentcicero-develop branch July 9, 2020 23:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

Assignees

@adlerjohn adlerjohn

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@SilentCicero @adlerjohn