Use #![deny(unused_crate_dependencies)] instead of udeps
#391
Conversation
xgreenx
changed the title
#![deny(unused_crate_dependencies)] instead of unused#![deny(unused_crate_dependencies)] instead of udeps
| # Note that, while we don't use this dependency directly, we must specify it in | ||
| # order to enable the transitive dependency's "js" feature which is required | ||
| # for supporting the wasm32-unknown-unknown target. | ||
| [target.'cfg(target_arch = "wasm32")'.dependencies] |
There was a problem hiding this comment.
I'm only trying to figure out this part. @mitchmindtree Added it before=) He may know if we still need it or not. Usually, the js feature is required if you try to use the std code in the WASM.
cargo check --target wasm32-unknown-unknown -p fuel-crypto --no-default-features compiles successfully for me
There was a problem hiding this comment.
I think this was potentially to help address the wasm issues the indexer was having? Does it still compile to wasm with --features random enabled?
There was a problem hiding this comment.
hmm it seems we can't build fuel-crypto for wasm with secp256k1 enabled 🤔
There was a problem hiding this comment.
Does it still compile to wasm with --features random enabled?
Yeah, it compiles with cargo build --target wasm32-unknown-unknown -p fuel-crypto --no-default-features --features random
|
If you're trying to address the ICE, it looks like it was already fixed by the Rust team: rust-lang/rust#109199. We might just need to wait until the next nightly version for CI to work again. But finding the unused dependencies is a nice bonus here. |
|
Another bonus of all tests in one module is that it compiles tests for me much faster. I would say 10 seconds versus 1 min=) |
Makes sense, that's why we use a custom test harness in fuel-core so we don't have to link rocksdb into dozens of binary targets for each integ test module. |
fuel-crypto/Cargo.toml
Outdated
| [dev-dependencies] | ||
| bincode = { version = "1.3", default-features = false } | ||
| criterion = "0.3" | ||
| fuel-crypto = { path = ".", default-features = false, features = ["random"] } | ||
| fuel-crypto = { path = ".", default-features = false, features = ["random", "serde"] } |
There was a problem hiding this comment.
should this be only enabled via the serde feature flag?
There was a problem hiding this comment.
Removed it, but it adds code like
#[cfg(feature = "serde")]
mod serde;
#[cfg(not(feature = "serde"))]
use bincode as _;
fuel-tx/Cargo.toml
Outdated
| fuel-crypto = { workspace = true, default-features = false, features = ["random"] } | ||
| fuel-tx = { path = ".", features = ["builder", "random"] } | ||
| fuel-tx = { path = ".", features = ["builder", "random", "serde"] } |
There was a problem hiding this comment.
Also should only be enabled when the serde feature is turned on
| fuel-tx = { path = ".", features = ["builder", "random", "serde"] } | |
| fuel-tx = { path = ".", features = ["builder", "random"] } |
There was a problem hiding this comment.
Added
#[cfg(feature = "serde")]
mod bytes;
#[cfg(feature = "serde")]
mod display;
#[cfg(not(feature = "serde"))]
use bincode as _;
The CI fails with the latest nightly Rust for
udeps. This PR removes the usage of theudepsand replaces it withunused_crate_dependencies. Because of specific how linting works, I moved alltestsfolders into thesrcfolder and compile integration tests as one module. Also, it improved the compilation time for tests(see for details why). Also found several unused dependencies withunused_crate_dependencies