Update refresh-manifests job to only commit manifests if *all* platforms succeed (not just Linux)
#70
Labels
bug
Something isn't working
Comments
This was referenced Jun 1, 2023
Merged
mitchmindtree
added a commit
that referenced
this issue
Jun 2, 2023
mitchmindtree
added a commit
that referenced
this issue
Jun 2, 2023
mitchmindtree
added a commit
that referenced
this issue
Jun 2, 2023
…ifests (#73) Closes #70 Closes #71 The new workflow has three main jobs: 1. Refresh the manifests using the `refresh-manifests.sh` script and upload the `manifests` directory to temporary workflow storage. 2. If `1.` succeeds: For all supported platforms and all major package sets (fuel, fuel-nightly, fuel-beta-3, etc), download the new manifests from temporary storage, add them to git staging so they get picked up by nix, then do a test nix build. Cache the binaries on success. 3. If `2.` succeeds: Download the manifests from temporary storage, commit them to master and push to the main master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
refresh-manifestsjob only tests on the ubuntu runner before committing the new manifests.This was fine when the repo was first created, as the flake was only targeted at Linux users. However, now that we aim to use this to distribute binaries for macOS users too, we should ensure all platforms pass to avoid letting platform-specific issues like #64 slip through the cracks.
This might be tricky as we'll want to split the job of running
refresh-manifestsand testing on all platforms into separate steps, but we need to make the manifests available from the first step to the next without actually committing them 🤔The text was updated successfully, but these errors were encountered: