Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage slot initialization for contract deployment #1117

Closed
cold-briu opened this issue Aug 30, 2023 · 0 comments · Fixed by #1120
Closed

Add storage slot initialization for contract deployment #1117

cold-briu opened this issue Aug 30, 2023 · 0 comments · Fixed by #1120
Assignees
Labels
enhancement New feature or request

Comments

@cold-briu
Copy link
Contributor

cold-briu commented Aug 30, 2023

As seen in sway/4634

Storage initialization values won't be automatically set by the sdk since the initialization values are output into a separate json file from the abi.

The sdk should automatically include storage slots. Otherwise, an additional config step is required to deploy the contract as seen here.

This is the fix for the same issue on fuels-ts.

@segfault-magnet segfault-magnet self-assigned this Aug 30, 2023
@segfault-magnet segfault-magnet added the enhancement New feature or request label Aug 30, 2023
IGI-111 pushed a commit to FuelLabs/sway that referenced this issue Aug 30, 2023
## Description

- Bumps the test harness for the
[quickstart](https://github.com/FuelLabs/fuel-docs/blob/master/src/quickstart/smart-contract.md)
to match beta-4

- Adds [changes ](FuelLabs/fuel-docs#102)
suggested by @segfault-magnet for storage initialization on rust sdk
testing. Due to the sdk storage initialization issue
[fuels-rs/issues/111](FuelLabs/fuels-rs#1117)

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants