Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: capture error from reverting transactions in the SDK #103

Merged
merged 7 commits into from
Feb 21, 2022
Merged

feat: capture error from reverting transactions in the SDK #103

merged 7 commits into from
Feb 21, 2022

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Feb 16, 2022 •
edited

@iqdecay iqdecay linked an issue Feb 16, 2022 that may be closed by this pull request
Investigate why some errors at the fuel-core / fuel-vm level aren’t being captured by the SDK #102
Closed
@iqdecay iqdecay self-assigned this Feb 16, 2022
@iqdecay iqdecay added the bug Something isn't working label Feb 16, 2022
digorithm
digorithm requested changes Feb 16, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome; major debugging QoL improvement. Just left one small request.

fuels-contract/src/script.rs Outdated Show resolved Hide resolved
vlopes11
vlopes11 reviewed Feb 17, 2022
View reviewed changes
Copy link

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

fuels-abigen-macro/tests/harness.rs Outdated Show resolved Hide resolved
@adlerjohn
Copy link
Contributor

cc @digorithm for re-review

digorithm
digorithm approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@iqdecay iqdecay merged commit 8e57d24 into master Feb 21, 2022
@iqdecay iqdecay deleted the vnepveu/fix-error-capture branch February 21, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@vlopes11 vlopes11 Awaiting requested review from vlopes11

Assignees

@iqdecay iqdecay

Labels
bug Something isn't working
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate why some errors at the fuel-core / fuel-vm level aren’t being captured by the SDK
4 participants
@iqdecay @adlerjohn @digorithm @vlopes11