feat!: add String support
#1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqdecay
requested review from
digorithm,
hal3e,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
iqdecay
force-pushed
the
iqdecay/feat-dynamic-string-output
branch
2 times, most recently
from
2193c94
to
bcbbeee
Compare
There was a problem hiding this comment.
Beautifully done!!
As for the open sway issue, you can test your understanding of the encoding by leaving the SDK out and using a plain ol' sway script calling a sway contract via forc.
Log the received data and do these assertions and see if they hold up.
Not approving yet since the issue might have to do with our encoding (albeit that seems unlikely if String really just uses Bytes under the hood).
iqdecay
force-pushed
the
iqdecay/feat-dynamic-string-output
branch
from
c61f0e4
to
49a8f42
Compare
6 tasks
iqdecay
force-pushed
the
iqdecay/feat-dynamic-string-output
branch
from
49a8f42
to
831336d
Compare
|
Marking as draft until I figure out what is wrong with my encoding. |
Mostly @iqdecay, I added some tests and fixed the encoding bug.
Adding an issue now. |
Salka1988
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is dependent on Sway
v0.42, and therefore will need #997 before being effective (fuel-core 0.19).This PR closes #1011 by adding support for Sway's
std::string::Stringtype.ParamTypeintroduced here is calledParamType::StdStringbecauseParamType::Stringrepresents statically-sized Sway strings. I think it would be better to useStringfor the dynamic type, andStaticStringfor statically-sized ones, but I think this refactoring would make the PR less clear.I need to figure out what's wrong with how I encode theStringdata, this is why the test is weird.