Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use REG_CGAS as default forwarded gas #1122

Merged
merged 4 commits into from
Sep 6, 2023
Merged

feat: use REG_CGAS as default forwarded gas #1122

merged 4 commits into from
Sep 6, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Sep 5, 2023

Use REG_CGAS register if no gas_forwarded was not set for a specific call.

Checklist

  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e added the tech-debt Improves code quality or safety label Sep 5, 2023
@hal3e hal3e self-assigned this Sep 5, 2023
digorithm
digorithm previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean change -- LGTM.

@Voxelot
Copy link
Member

Voxelot commented Sep 5, 2023

Nice, should save a few extra precious bytes when txs are serialized.

MujkicA
MujkicA previously approved these changes Sep 5, 2023
View reviewed changes
Br1ght0ne
Br1ght0ne previously approved these changes Sep 5, 2023
View reviewed changes
@hal3e
Copy link
Contributor Author

hal3e commented Sep 5, 2023

Thank you very much for reviewing this so quickly!

I have made a small change where the gas_forwarded is not added to the data at all if it is not set.

@hal3e hal3e dismissed stale reviews from Br1ght0ne, MujkicA, and digorithm via 377698d September 5, 2023 21:15
@hal3e
Copy link
Contributor Author

hal3e commented Sep 6, 2023

Special thanks to @MujkicA for helping me on this task!

@hal3e hal3e merged commit 02422a7 into master Sep 6, 2023
36 checks passed
@hal3e hal3e deleted the feat/use_reg_cgas branch September 6, 2023 07:34
@hal3e hal3e mentioned this pull request Oct 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@iqdecay iqdecay Awaiting requested review from iqdecay

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

Assignees

@hal3e hal3e

Labels
tech-debt Improves code quality or safety
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hal3e @Voxelot @digorithm @Br1ght0ne @Salka1988 @MujkicA @segfault-magnet