feat: connect to already deployed contracts #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the `compiled_contract` argument was used only for computing the `contract_id`
nfurfaro
reviewed
Feb 25, 2022
nfurfaro
reviewed
Feb 25, 2022
adlerjohn
reviewed
Feb 26, 2022
There was a problem hiding this comment.
Looks reasonable. Will defer to @digorithm for final review.
digorithm
requested changes
Feb 27, 2022
adlerjohn
reviewed
Feb 27, 2022
|
Tiny conflict with |
digorithm
reviewed
Mar 3, 2022
adlerjohn
reviewed
Mar 3, 2022
digorithm
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
LGTM. Let's keep in mind that this is a breaking change -- we're moving from creating a contract instance with the compiled contract to taking only the contract id. All tests out there will break with this change. It will require minimal changes on the user side, though, similar to the changes in harness.rs in this PR.
adlerjohn
approved these changes
Mar 3, 2022
iqdecay
added a commit
to FuelLabs/sway
that referenced
this pull request
Mar 3, 2022
iqdecay
added a commit
to FuelLabs/sway
that referenced
this pull request
Mar 5, 2022
* In accordance with FuelLabs/fuels-rs#113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88.
This PR changes the way to instantiate a contract. Since the compiled code is actually not needed
to interact with the contract, we just provide the
contract_id.This PR also creates a "default instantiation" for contracts, mainly for test purposes.
Comment: not sure about some design choices around string or
new_default.