Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check deploy tx status #1145

Merged
merged 6 commits into from
Oct 4, 2023
Merged

feat: check deploy tx status #1145

merged 6 commits into from
Oct 4, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Sep 27, 2023

close: #1141

This PR adds a check of the tx status when deploying contracts.
I have refactored the code a bit and added a new error variant SqueezedOutTransactionError. I am not sure if this should be an error. What do you think @FuelLabs/sdk-rust ?

Checklist

  • I have linked to any relevant issues.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e added the tech-debt Improves code quality or safety label Sep 27, 2023
@hal3e hal3e self-assigned this Sep 27, 2023
digorithm
digorithm previously approved these changes Sep 27, 2023
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I believe this new error should be bubbled up to the SDK user.

Br1ght0ne
Br1ght0ne previously approved these changes Sep 27, 2023
@hal3e hal3e dismissed stale reviews from Br1ght0ne and digorithm via 1df7327 October 3, 2023 09:32
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to make it an SDK error, it is the same class of mistake as a revert for instance.

@hal3e hal3e merged commit cb2efdc into master Oct 4, 2023
38 checks passed
@hal3e hal3e deleted the feat/check-deploy-tx-status branch October 4, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Improves code quality or safety
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract deployment is not being checked for failure
6 participants