Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get TransactionBuilder from script and contract calls #1220

Merged
merged 38 commits into from Nov 29, 2023
Merged

feat: get TransactionBuilder from script and contract calls #1220

merged 38 commits into from Nov 29, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Nov 28, 2023

close: #1147, #923
co-developed with: @MujkicA

New features:

  • TransationBuilders can be extracted from contract and scriptcalls.
  • FuelResponse can be made from a TxStatus. This is useful to decode return values and logs.
  • New documentation regarding TransactionBuilders and custom transactions

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

hal3e and others added 30 commits November 14, 2023 00:38
@hal3e hal3e added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 28, 2023
@hal3e hal3e self-assigned this Nov 28, 2023
@hal3e hal3e changed the title feat: add ` feat: get TransactionBuilders from script and contract calls Nov 28, 2023
@hal3e hal3e changed the title feat: get TransactionBuilders from script and contract calls feat: get TransactionBuilder from script and contract calls Nov 28, 2023
segfault-magnet
segfault-magnet reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@segfault-magnet segfault-magnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some automated spelling stuff.

And the author on the sway project needs to be changed.

packages/fuels/tests/predicates/swap/Forc.toml Outdated Show resolved Hide resolved
docs/src/custom-transactions/index.md Outdated Show resolved Hide resolved
docs/src/custom-transactions/transaction-builders.md Outdated Show resolved Hide resolved
docs/src/custom-transactions/transaction-builders.md Outdated Show resolved Hide resolved
docs/src/custom-transactions/transaction-builders.md Outdated Show resolved Hide resolved
docs/src/custom-transactions/transaction-builders.md Outdated Show resolved Hide resolved
hal3e and others added 2 commits November 29, 2023 20:32
@hal3e
change author
89e0e17
@hal3e @segfault-magnet
Apply suggestions from code review
8d9e0e1 
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
@hal3e hal3e merged commit ce7c0b4 into master Nov 29, 2023
39 checks passed
@hal3e hal3e deleted the hal3e/tx-status-log-and-response branch November 29, 2023 20:26
@hal3e hal3e mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@MujkicA MujkicA MujkicA approved these changes

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@iqdecay iqdecay Awaiting requested review from iqdecay

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@MujkicA MujkicA

@hal3e hal3e

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documenting custom transactions
5 participants
@hal3e @Br1ght0ne @MujkicA @segfault-magnet @digorithm