Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent overflow while decoding param types #1227

Merged
merged 11 commits into from
Jan 10, 2024

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Dec 8, 2023

Closes #1215 by fixing the way encoding size is computed

@iqdecay iqdecay changed the title fix: prevent overflow while encoding param types fix: prevent overflow while decoding param types Dec 8, 2023
@iqdecay iqdecay force-pushed the iqdecay/fix-decoding-add-overflow branch from 73aa573 to 1c3f876 Compare December 8, 2023 20:52
@iqdecay iqdecay self-assigned this Dec 9, 2023
Br1ght0ne
Br1ght0ne previously approved these changes Dec 13, 2023
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job finding this issue and fixing it. LGTM, but I agree with @MujkicA's suggestions; it'll make a lot nicer to the eyes.

@iqdecay
Copy link
Contributor Author

iqdecay commented Jan 6, 2024

@FuelLabs/sdk-rust can we please move this forward

@iqdecay iqdecay enabled auto-merge (squash) January 10, 2024 13:45
@iqdecay iqdecay merged commit 351dc72 into master Jan 10, 2024
43 checks passed
@iqdecay iqdecay deleted the iqdecay/fix-decoding-add-overflow branch January 10, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: decode_multiple can overflow
5 participants