Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use receipts from TransactionStatus #1234

Merged
merged 3 commits into from Dec 13, 2023
Merged

refactor: use receipts from TransactionStatus #1234

merged 3 commits into from Dec 13, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Dec 12, 2023

fuel-core now provides receipts inside the TransactionStatus.

Checklist

  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e added the tech-debt Improves code quality or safety label Dec 12, 2023
@hal3e hal3e self-assigned this Dec 12, 2023
iqdecay
iqdecay previously approved these changes Dec 12, 2023
View reviewed changes
digorithm
digorithm approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful -- thanks again @xgreenx and team for moving this complexity to the client.

packages/fuels-accounts/src/provider.rs Show resolved Hide resolved
@iqdecay iqdecay mentioned this pull request Dec 12, 2023
Closed
@hal3e hal3e merged commit cb2e4c8 into master Dec 13, 2023
40 checks passed
@hal3e hal3e deleted the hal3e/tx-status-receipts branch December 13, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@iqdecay iqdecay iqdecay approved these changes

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne Br1ght0ne is a code owner

Assignees

@hal3e hal3e

Labels
tech-debt Improves code quality or safety
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hal3e @digorithm @Salka1988 @iqdecay