fix: use only base asset amount when calculating fee #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoplavkov
requested review from
digorithm,
iqdecay,
hal3e,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
digorithm
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Nice catch. The solution seems reasonable to me; can't think of anything wrong that this could lead up to, at the moment.
The CI is failing because of a tiny formatting issue; make sure to rustfmt the code.
Invoking some of the guys that worked on fees to double-check this solution: @MujkicA @hal3e @segfault-magnet
digorithm
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Many thanks, @mpoplavkov! We'll cut a new release with this change asap.
|
Awesome, thanks! |
Salka1988
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the issue #1239