Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add conversion from Address/ContractId types to Identity #1252

Merged
merged 5 commits into from Jan 25, 2024
Merged

feat: add conversion from Address/ContractId types to Identity #1252

merged 5 commits into from Jan 25, 2024

Conversation

dmihal
Copy link
Contributor

@dmihal dmihal commented Jan 22, 2024 •
edited

Convert from Address/Bech32Address/ContractId/Bech32ContractId to Identity easily

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@dmihal dmihal added enhancement New feature or request fuel-core Requires more info or is blocked by fuel-core labels Jan 22, 2024
@iqdecay
Copy link
Contributor

iqdecay commented Jan 22, 2024 •
edited

This PR reminds me of this old discussion.

iqdecay
iqdecay previously approved these changes Jan 22, 2024
View reviewed changes
digorithm
digorithm reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, these seem like handy conversion methods.

Some tests are failing, though.

MujkicA
MujkicA previously approved these changes Jan 24, 2024
View reviewed changes
@Br1ght0ne Br1ght0ne dismissed stale reviews from iqdecay and MujkicA via fea283b January 25, 2024 10:48
@hal3e hal3e changed the title Implement conversion between Address/ContractId types and Identity feat: add conversion from Address/ContractId types to Identity Jan 25, 2024
hal3e
hal3e approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Br1ght0ne Br1ght0ne merged commit 2e22a60 into master Jan 25, 2024
40 checks passed
@Br1ght0ne Br1ght0ne deleted the dmihal/identity-convertions branch January 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm left review comments

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@MujkicA MujkicA MujkicA approved these changes

@hal3e hal3e hal3e approved these changes

@iqdecay iqdecay iqdecay left review comments

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request fuel-core Requires more info or is blocked by fuel-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dmihal @iqdecay @digorithm @Br1ght0ne @MujkicA @hal3e