Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a connect method to connect to existing nodes #129

Merged
merged 15 commits into from
Mar 5, 2022

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Mar 3, 2022

This PR closes #115 by implementing a connect function to connect to already running client.

@iqdecay iqdecay requested a review from digorithm as a code owner March 3, 2022 18:00
@iqdecay iqdecay linked an issue Mar 3, 2022 that may be closed by this pull request
Base automatically changed from vnepveu/feat-connect-existing-contract to master March 3, 2022 18:08
@iqdecay iqdecay added the enhancement New feature or request label Mar 3, 2022
@iqdecay iqdecay requested a review from adlerjohn March 3, 2022 23:02
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will defer to @digorithm

Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iqdecay iqdecay merged commit a6355a8 into master Mar 5, 2022
@iqdecay iqdecay deleted the feat-connect-node branch March 5, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement a connect function for nodes
3 participants