fix: transaction builder no_input_to_cover_fees
#1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
requested review from
digorithm,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
MujkicA
reviewed
Mar 20, 2024
MujkicA
previously approved these changes
Mar 26, 2024
digorithm
previously approved these changes
Mar 26, 2024
|
Guys, when do you plan to release this fix? |
segfault-magnet
previously approved these changes
Mar 28, 2024
hal3e
dismissed stale reviews from segfault-magnet, digorithm, and MujkicA
via
b6cef89
MujkicA
approved these changes
Mar 29, 2024
segfault-magnet
approved these changes
Mar 29, 2024
chlenc
approved these changes
Mar 29, 2024
PaulZhemanov
approved these changes
Mar 29, 2024
digorithm
approved these changes
Mar 29, 2024
It's been published just now: https://github.com/FuelLabs/fuels-rs/releases/tag/v0.55.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
no_spendable_inputwas not checking if theasset_idwas the base asset. Coins with other asset_ids can not be used to cover the tx fee.