New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: upgrade fuel-core to 24.2 #1319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MujkicA
requested review from
digorithm,
hal3e,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
April 4, 2024 14:11
MujkicA
commented
Apr 4, 2024
MujkicA
commented
Apr 4, 2024
…s/fuels-rs into feature/upgrade-fuel-core-0.24.1
Our rocksdb test is failing due to a bug on the core side. Disabling it for now Tracked here: #1324 |
hal3e
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Left some comments.
MujkicA
changed the title
feat!: upgrade fuel-core to 24.1
feat!: upgrade fuel-core to 24.2
Apr 5, 2024
CI isn't passing :( |
…s/fuels-rs into feature/upgrade-fuel-core-0.24.1
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
…s/fuels-rs into feature/upgrade-fuel-core-0.24.1
segfault-magnet
approved these changes
Apr 10, 2024
Salka1988
approved these changes
Apr 10, 2024
Br1ght0ne
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FuelService::new
to keepsetup_test_provider
stable.BREAKING CHANGE
Config
toNodeConfig
NodeConfig
no longer holds ChainConfig`ChainConfig
inStateConfig
FuelService::start()
now acceptsNodeConfig
,ChainConfig
andStateConfig
as arguments to startup a node.ConsensusParameters
being an enum to support versioning, when instantiating it, we need to make use of setters if we want to avoid committing to a specific version:Fields need to be accessed via methods:
The same applies to other parameter structs used when setting up the node, like
TxParameters
,ContractParameters
,PredicateParameters
etc.The
witness_index
parameters inCreateTransactionBuilder::with_bytecode_witness_index
is now au16
NodeInfo
no longer hasmin_gas_price
CreateTransaction
no longer hasbytecode_length()
Header
no longer has message_receipt_root but gains:Checklist