feat!: improve error on malformed abi
#1347
Merged
+212
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
requested review from
digorithm,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
segfault-magnet
previously approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Would be nice if we could catch this before Abigen. Sometime while we still have the Span so that we may underline the ABI part of the macro.
We can change the AbigenTarget to contain the FullAbiProgram instead of the source.
But maybe for another time. Maybe an issue if you agree? Or a point in the neverending wish list @digorithm ?
|
I will give it a try int this PR |
hal3e
changed the title
abiabi
packages/fuels-code-gen/src/program_bindings/abigen/abigen_target.rs
Outdated
Show resolved
Hide resolved
segfault-magnet
previously approved these changes
May 2, 2024
MujkicA
approved these changes
May 3, 2024
segfault-magnet
approved these changes
May 3, 2024
Salka1988
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1343
BREAKING CHANGE:
AbigenTargetnow holds the parsedFullProgramAbiand the path.AbigenTargetandAbiarepub(crate)Sourceis removed in favor ofAbiChecklist