feat: version incompatibility is now a soft warning #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfault-magnet
requested review from
digorithm,
hal3e,
MujkicA,
Salka1988 and
Br1ght0ne
as code owners
digorithm
previously approved these changes
Apr 29, 2024
Br1ght0ne
previously approved these changes
Apr 29, 2024
Not sure. No from an API perspective (we still return results in affected places). We've changed only crate internal signatures. From a behavior perspective, yes. If somebody relied on a hard "no" when connecting to an incompatible node this will no longer happen. |
digorithm
approved these changes
Apr 30, 2024
Salka1988
approved these changes
Apr 30, 2024
xgreenx
approved these changes
Apr 30, 2024
hal3e
approved these changes
Apr 30, 2024
segfault-magnet
deleted the
feat/version_incompat_lessen_severity_of_err
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version incompatibility is now a soft error appended to every provider error.
Checklist