Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support static gas price setting in NodeConfig #1396

Merged
merged 49 commits into from
Jun 20, 2024
Merged

feat!: support static gas price setting in NodeConfig #1396

merged 49 commits into from
Jun 20, 2024

Conversation

MujkicA
Copy link
Contributor

@MujkicA MujkicA commented May 30, 2024 •
edited
Loading

Originally, this PR was aiming to solve several bugs and enables a static gas price in our tests so that we can catch said bugs.
It was split into several smaller PRs:
#1423, #1425, #1426

In it's current version, it only adds the static gas price config parameter to the node config and enables it in our tests.

BREAKING CHANGE: Adds the field static_gas_price to NodeConfig

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@MujkicA MujkicA self-assigned this May 30, 2024
@MujkicA MujkicA added enhancement New feature or request bug Something isn't working blocked labels Jun 3, 2024
@segfault-magnet segfault-magnet changed the base branch from master to dev June 6, 2024 12:35
@MujkicA MujkicA mentioned this pull request Jun 11, 2024
Merged
6 tasks
@hal3e hal3e changed the title feat!: Fix gas and fee estimation feat!: fix gas and fee estimation Jun 12, 2024
@hal3e hal3e changed the base branch from dev to master June 12, 2024 09:07
This was referenced Jun 12, 2024
Open
Open
@MujkicA MujkicA changed the title feat!: fix gas and fee estimation feat!: support static gas price setting in NodeConfig Jun 15, 2024
@MujkicA MujkicA marked this pull request as ready for review June 15, 2024 01:25
Br1ght0ne
Br1ght0ne previously approved these changes Jun 17, 2024
View reviewed changes
hal3e
hal3e requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Have left some nits

examples/cookbook/src/lib.rs Outdated Show resolved Hide resolved
packages/fuels-core/src/types/transaction_builders.rs Outdated Show resolved Hide resolved
@hal3e
Copy link
Contributor

hal3e commented Jun 18, 2024

can you please add the BREAKING CHANGE section in the PR description.

@hal3e hal3e changed the title feat!: support static gas price setting in NodeConfig feat!: support static gas price setting in NodeConfig Jun 18, 2024
@MujkicA @hal3e
Update examples/cookbook/src/lib.rs
cb8a9d4 
Co-authored-by: hal3e <git@hal3e.io>
@MujkicA MujkicA requested review from hal3e and Br1ght0ne June 19, 2024 09:18
hal3e
hal3e approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work! thanks

@MujkicA MujkicA enabled auto-merge (squash) June 19, 2024 11:22
@MujkicA MujkicA disabled auto-merge June 19, 2024 11:22
@MujkicA MujkicA enabled auto-merge (squash) June 19, 2024 11:23
@MujkicA MujkicA merged commit 3598af1 into master Jun 20, 2024
44 checks passed
@MujkicA MujkicA deleted the feature/fix-fee-limits branch June 20, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@hal3e hal3e hal3e approved these changes

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@MujkicA MujkicA

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MujkicA @hal3e @digorithm @Br1ght0ne