Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support the new Sway array type format #144

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Mar 8, 2022

This PR closes #111 by fixing the ABI parsing of the array type from T[n] to [T; n].
It also refactors the parsing of str[n] parameters and implements tests for both parsing.

@iqdecay iqdecay requested a review from digorithm as a code owner March 8, 2022 21:10
@iqdecay iqdecay changed the title fix: support the new Sway array supports fix: support the new Sway array format Mar 8, 2022
@iqdecay iqdecay changed the title fix: support the new Sway array format fix: support the new Sway array type format Mar 8, 2022
@iqdecay iqdecay self-assigned this Mar 8, 2022
@iqdecay iqdecay added the bug Something isn't working label Mar 8, 2022
@iqdecay iqdecay requested a review from adlerjohn March 8, 2022 21:11
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, good work on this. Just left some comments on better error handling.

fuels-core/src/json_abi.rs Outdated Show resolved Hide resolved
fuels-core/src/json_abi.rs Outdated Show resolved Hide resolved
@iqdecay iqdecay requested a review from digorithm March 9, 2022 19:58
@iqdecay iqdecay merged commit 29ce4f2 into master Mar 9, 2022
@iqdecay iqdecay deleted the vnepveu/fix-array-support branch March 9, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix support for arrays
2 participants