Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix clippy warnings #145

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Mar 8, 2022

This PR closes #76 so it's easier to detect when you trigger a clippy warning.

@iqdecay iqdecay requested a review from digorithm as a code owner March 8, 2022 21:58
@iqdecay iqdecay self-assigned this Mar 8, 2022
@iqdecay iqdecay added enhancement New feature or request tech-debt Improves code quality or safety labels Mar 8, 2022
@iqdecay iqdecay linked an issue Mar 8, 2022 that may be closed by this pull request
@iqdecay iqdecay force-pushed the vnepveu/style-fix-clippy-warnings branch from 66cf1af to 841c6ff Compare March 8, 2022 22:02
@adlerjohn
Copy link
Contributor

Is this supposed to be against vnepveu/fix-array-support?

@iqdecay iqdecay changed the base branch from vnepveu/fix-array-support to master March 8, 2022 22:03
@iqdecay
Copy link
Contributor Author

iqdecay commented Mar 8, 2022

messed up, I changed it. Had to force-push my way out of it lol.

@iqdecay iqdecay force-pushed the vnepveu/style-fix-clippy-warnings branch from 841c6ff to 1bfd7eb Compare March 8, 2022 22:08
@iqdecay iqdecay requested a review from adlerjohn March 8, 2022 22:09
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@iqdecay iqdecay merged commit 73eb508 into master Mar 9, 2022
@iqdecay iqdecay deleted the vnepveu/style-fix-clippy-warnings branch March 9, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech-debt Improves code quality or safety
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix clippy warnings
3 participants