feat: sign transactions before submitting them to the client #160
Conversation
There was a problem hiding this comment.
The "sign transactions before submission" portion isn't tested because I struggled
to find a way to meaningfully test the whole workflow. Feel free to chime in with ideas
if you think this is important, but to me the unit tests are enough.
IMO that's good enough for now.
I think that for this to be properly tested, the Sway contract that we deploy with a given signature, would have to check, in its ABI method, say, foo(), if the caller of foo() (who signed the call) is the one who signed the deployment, something like Solidity's owner() modifier. This way we could verify that they match. But that would be basically testing Sway + core (including tx, VM) abilities to verify signatures -- not sure this would be valuable at the SDK level. That could be a longer discussion and we can prioritize that for later.
to find a way to meaningfully test the whole workflow. Feel free to chime in with ideas
if you think this is important, but to me the unit tests are enough.