Fix multi-argument contract calls #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @AlicanC @luizstacio this probably should also be implemented on |
I had implemented it on this PR: FuelLabs/fuels-ts#170 |
iqdecay
suggested changes
Mar 25, 2022
fuels-contract/src/contract.rs
Outdated
| external_contracts: None, | ||
| wallet: wallet.clone(), | ||
| }) | ||
| } | ||
|
|
||
| // Returns true if the method call takes custom inputs or has more than one argument. This is used to determine whether we need to compute the `call_data_offset`. | ||
| fn should_compute_call_data_offset(args: &[Token]) -> bool { | ||
| match args.iter().any(|t| matches!(t, Token::Struct(_))) { |
There was a problem hiding this comment.
Shouldn't we also check for Enum and in the future Tuples?
There was a problem hiding this comment.
Yes for enums. Tuples might or might not be a thing, we'll see once the time comes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls with multiple arguments, for instance
Were broken due to how we compute the call data offset. Before, we added this extra offset only if the argument was a custom type. Turns out, if you have more than one argument, you also need that. The only moment you don't need this extra offset is when the method takes only one arg and it's not a custom type.
This PR makes some simple, non-breaking changes to check whether we should or not compute this offset.