make fuel-core optional in fuels-signers #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digorithm
previously approved these changes
May 4, 2022
|
found it was also being included by fuels-contracts because it was enabling test-helpers in signers by default, even though it doesn't use the helpers. |
Nice catch! |
digorithm
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #250
Running a local copy of fuel-core from fuel-signers::Provider is purely a convenience function for local testing. However, when using the SDK in production services, we shouldn't be including the extra dependencies from fuel-core as they're unnecessary when calling a remote fuel-core node.